Enrico
5b9b70d29c
session_before_compact and session_compact now carry
reason ("manual" | "threshold" | "overflow") and willRetry, matching
what the RPC protocol already exposes via auto_compaction_start/end.
Extensions can now distinguish manual /compact from threshold
auto-compaction and overflow recovery through the public API instead
of monkeypatching AgentSession internals.
96 lines
3.2 KiB
TypeScript
96 lines
3.2 KiB
TypeScript
import { fauxAssistantMessage } from "@earendil-works/pi-ai";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import type { ExtensionFactory } from "../../../src/index.ts";
|
|
import { createHarness, type Harness } from "../harness.ts";
|
|
|
|
type SessionWithCompactionInternals = {
|
|
_runAutoCompaction: (reason: "overflow" | "threshold", willRetry: boolean) => Promise<boolean>;
|
|
};
|
|
|
|
interface RecordedCompactionEvent {
|
|
type: "session_before_compact" | "session_compact";
|
|
reason: "manual" | "threshold" | "overflow";
|
|
willRetry: boolean;
|
|
}
|
|
|
|
function recordingExtension(recorded: RecordedCompactionEvent[]): ExtensionFactory {
|
|
return (pi) => {
|
|
pi.on("session_before_compact", async (event) => {
|
|
recorded.push({ type: event.type, reason: event.reason, willRetry: event.willRetry });
|
|
return {
|
|
compaction: {
|
|
summary: "summary from extension",
|
|
firstKeptEntryId: event.preparation.firstKeptEntryId,
|
|
tokensBefore: event.preparation.tokensBefore,
|
|
details: {},
|
|
},
|
|
};
|
|
});
|
|
pi.on("session_compact", async (event) => {
|
|
recorded.push({ type: event.type, reason: event.reason, willRetry: event.willRetry });
|
|
});
|
|
};
|
|
}
|
|
|
|
async function createCompactionHarness(recorded: RecordedCompactionEvent[]): Promise<Harness> {
|
|
const harness = await createHarness({
|
|
settings: { compaction: { keepRecentTokens: 1 } },
|
|
extensionFactories: [recordingExtension(recorded)],
|
|
});
|
|
harness.setResponses([fauxAssistantMessage("one"), fauxAssistantMessage("two")]);
|
|
await harness.session.prompt("first");
|
|
await harness.session.prompt("second");
|
|
return harness;
|
|
}
|
|
|
|
describe("issue #5217 compaction reason on extension events", () => {
|
|
const harnesses: Harness[] = [];
|
|
|
|
afterEach(() => {
|
|
while (harnesses.length > 0) {
|
|
harnesses.pop()?.cleanup();
|
|
}
|
|
});
|
|
|
|
it("reports manual reason for compact()", async () => {
|
|
const recorded: RecordedCompactionEvent[] = [];
|
|
const harness = await createCompactionHarness(recorded);
|
|
harnesses.push(harness);
|
|
|
|
await harness.session.compact();
|
|
|
|
expect(recorded).toEqual([
|
|
{ type: "session_before_compact", reason: "manual", willRetry: false },
|
|
{ type: "session_compact", reason: "manual", willRetry: false },
|
|
]);
|
|
});
|
|
|
|
it("reports threshold reason for auto-compaction", async () => {
|
|
const recorded: RecordedCompactionEvent[] = [];
|
|
const harness = await createCompactionHarness(recorded);
|
|
harnesses.push(harness);
|
|
const sessionInternals = harness.session as unknown as SessionWithCompactionInternals;
|
|
|
|
await sessionInternals._runAutoCompaction("threshold", false);
|
|
|
|
expect(recorded).toEqual([
|
|
{ type: "session_before_compact", reason: "threshold", willRetry: false },
|
|
{ type: "session_compact", reason: "threshold", willRetry: false },
|
|
]);
|
|
});
|
|
|
|
it("reports overflow reason and willRetry for overflow recovery", async () => {
|
|
const recorded: RecordedCompactionEvent[] = [];
|
|
const harness = await createCompactionHarness(recorded);
|
|
harnesses.push(harness);
|
|
const sessionInternals = harness.session as unknown as SessionWithCompactionInternals;
|
|
|
|
await sessionInternals._runAutoCompaction("overflow", true);
|
|
|
|
expect(recorded).toEqual([
|
|
{ type: "session_before_compact", reason: "overflow", willRetry: true },
|
|
{ type: "session_compact", reason: "overflow", willRetry: true },
|
|
]);
|
|
});
|
|
});
|