ton/pi_harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent): reject non-positive bash timeouts

Browse Source
This commit is contained in:
Vegard Stikbakke
2026-07-01 09:03:00 +02:00
parent cbcf4e04c3
commit 85b7c24741
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/agent/src/harness/env/nodejs.ts
Vendored
+1 -2
View File
@@ -33,10 +33,9 @@ const MAX_TIMEOUT_SECONDS = MAX_TIMEOUT_MS / 1000;
function resolveTimeoutMs(timeout: number | undefined): Result<number | undefined, ExecutionError> { function resolveTimeoutMs(timeout: number | undefined): Result<number | undefined, ExecutionError> {
if (timeout === undefined) return ok(undefined); if (timeout === undefined) return ok(undefined);
if (!Number.isFinite(timeout)) { if (!Number.isFinite(timeout) || timeout <= 0) {
return err(new ExecutionError("timeout", "Invalid timeout: must be a finite number of seconds")); return err(new ExecutionError("timeout", "Invalid timeout: must be a finite number of seconds"));
} }
if (timeout <= 0) return ok(undefined);
const timeoutMs = timeout * 1000; const timeoutMs = timeout * 1000;
if (timeoutMs > MAX_TIMEOUT_MS) { if (timeoutMs > MAX_TIMEOUT_MS) {
packages/coding-agent/src/core/tools/bash.ts
+1 -2
View File
@@ -26,10 +26,9 @@ const MAX_TIMEOUT_SECONDS = MAX_TIMEOUT_MS / 1000;
function resolveTimeoutMs(timeout: number | undefined): number | undefined { function resolveTimeoutMs(timeout: number | undefined): number | undefined {
if (timeout === undefined) return undefined; if (timeout === undefined) return undefined;
if (!Number.isFinite(timeout)) { if (!Number.isFinite(timeout) || timeout <= 0) {
throw new Error("Invalid timeout: must be a finite number of seconds"); throw new Error("Invalid timeout: must be a finite number of seconds");
} }
if (timeout <= 0) return undefined;
const timeoutMs = timeout * 1000; const timeoutMs = timeout * 1000;
if (timeoutMs > MAX_TIMEOUT_MS) { if (timeoutMs > MAX_TIMEOUT_MS) {