From 4f71b2d3b7be1441dec4619ac19b3c2778b172a8 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Mon, 22 Jun 2026 13:03:50 +0200 Subject: [PATCH] fix(coding-agent): clarify ZAI Coding Plan label closes #5965 --- packages/ai/README.md | 4 ++-- packages/coding-agent/CHANGELOG.md | 4 ++++ packages/coding-agent/README.md | 2 +- packages/coding-agent/docs/providers.md | 2 +- packages/coding-agent/src/cli/args.ts | 2 +- packages/coding-agent/src/core/provider-display-names.ts | 2 +- packages/coding-agent/test/model-registry.test.ts | 1 + 7 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/ai/README.md b/packages/ai/README.md index 428ef259..7fcd359b 100644 --- a/packages/ai/README.md +++ b/packages/ai/README.md @@ -68,7 +68,7 @@ Unified LLM API with automatic model discovery, provider configuration, token an - **xAI** - **OpenRouter** - **Vercel AI Gateway** -- **ZAI** (with separate Coding Plan China provider) +- **ZAI Coding Plan (Global)** (with separate China provider) - **MiniMax** - **Together AI** - **GitHub Copilot** (requires OAuth, see below) @@ -1123,7 +1123,7 @@ In Node.js environments, you can set environment variables to avoid passing API | Together AI | `TOGETHER_API_KEY` | | OpenRouter | `OPENROUTER_API_KEY` | | Vercel AI Gateway | `AI_GATEWAY_API_KEY` | -| zAI | `ZAI_API_KEY` | +| ZAI Coding Plan (Global) | `ZAI_API_KEY` | | ZAI Coding Plan (China) | `ZAI_CODING_CN_API_KEY` | | MiniMax | `MINIMAX_API_KEY` | | OpenCode Zen / OpenCode Go | `OPENCODE_API_KEY` | diff --git a/packages/coding-agent/CHANGELOG.md b/packages/coding-agent/CHANGELOG.md index a405f908..989572ba 100644 --- a/packages/coding-agent/CHANGELOG.md +++ b/packages/coding-agent/CHANGELOG.md @@ -2,6 +2,10 @@ ## [Unreleased] +### Changed + +- Renamed the displayed `zai` provider label to ZAI Coding Plan (Global) for clarity ([#5965](https://github.com/earendil-works/pi/issues/5965)). + ## [0.79.10] - 2026-06-22 ### New Features diff --git a/packages/coding-agent/README.md b/packages/coding-agent/README.md index 5dc991cc..765c7a2f 100644 --- a/packages/coding-agent/README.md +++ b/packages/coding-agent/README.md @@ -121,7 +121,7 @@ For each built-in provider, pi maintains a list of tool-capable models, updated - xAI - OpenRouter - Vercel AI Gateway -- ZAI +- ZAI Coding Plan (Global) - ZAI Coding Plan (China) - OpenCode Zen - OpenCode Go diff --git a/packages/coding-agent/docs/providers.md b/packages/coding-agent/docs/providers.md index 86f1de06..e97eba5d 100644 --- a/packages/coding-agent/docs/providers.md +++ b/packages/coding-agent/docs/providers.md @@ -63,7 +63,7 @@ pi | xAI | `XAI_API_KEY` | `xai` | | OpenRouter | `OPENROUTER_API_KEY` | `openrouter` | | Vercel AI Gateway | `AI_GATEWAY_API_KEY` | `vercel-ai-gateway` | -| ZAI | `ZAI_API_KEY` | `zai` | +| ZAI Coding Plan (Global) | `ZAI_API_KEY` | `zai` | | ZAI Coding Plan (China) | `ZAI_CODING_CN_API_KEY` | `zai-coding-cn` | | OpenCode Zen | `OPENCODE_API_KEY` | `opencode` | | OpenCode Go | `OPENCODE_API_KEY` | `opencode-go` | diff --git a/packages/coding-agent/src/cli/args.ts b/packages/coding-agent/src/cli/args.ts index 5d3c4af8..899241c4 100644 --- a/packages/coding-agent/src/cli/args.ts +++ b/packages/coding-agent/src/cli/args.ts @@ -352,7 +352,7 @@ ${chalk.bold("Environment Variables:")} TOGETHER_API_KEY - Together AI API key OPENROUTER_API_KEY - OpenRouter API key AI_GATEWAY_API_KEY - Vercel AI Gateway API key - ZAI_API_KEY - ZAI API key + ZAI_API_KEY - ZAI Coding Plan API key (Global) ZAI_CODING_CN_API_KEY - ZAI Coding Plan API key (China) MISTRAL_API_KEY - Mistral API key MINIMAX_API_KEY - MiniMax API key diff --git a/packages/coding-agent/src/core/provider-display-names.ts b/packages/coding-agent/src/core/provider-display-names.ts index 9b0371d2..d33c3d7d 100644 --- a/packages/coding-agent/src/core/provider-display-names.ts +++ b/packages/coding-agent/src/core/provider-display-names.ts @@ -26,7 +26,7 @@ export const BUILT_IN_PROVIDER_DISPLAY_NAMES: Record = { together: "Together AI", "vercel-ai-gateway": "Vercel AI Gateway", xai: "xAI", - zai: "ZAI", + zai: "ZAI Coding Plan (Global)", "zai-coding-cn": "ZAI Coding Plan (China)", xiaomi: "Xiaomi MiMo", "xiaomi-token-plan-cn": "Xiaomi MiMo Token Plan (China)", diff --git a/packages/coding-agent/test/model-registry.test.ts b/packages/coding-agent/test/model-registry.test.ts index 1479808a..bc6496d8 100644 --- a/packages/coding-agent/test/model-registry.test.ts +++ b/packages/coding-agent/test/model-registry.test.ts @@ -885,6 +885,7 @@ describe("ModelRegistry", () => { expect(registry.getProviderDisplayName("openai")).toBe("OpenAI"); expect(registry.getProviderDisplayName("github-copilot")).toBe("GitHub Copilot"); + expect(registry.getProviderDisplayName("zai")).toBe("ZAI Coding Plan (Global)"); expect(registry.getProviderDisplayName("unknown-provider")).toBe("unknown-provider"); registry.registerProvider("named-provider", {