update

src/llmfunction.jl

@@ -99,7 +99,7 @@ function virtualWineCustomerReccommendbox(a::T1, input
       :text=> prompt,
     )
   )
-  @show outgoingMsg
+
   result = GeneralUtils.sendReceiveMqttMsg(outgoingMsg; timeout=120)
   response = result[:response]
 
@@ -162,28 +162,23 @@ function virtualWineCustomerChatbox(a::T1, input::T2
   )
 
   attempt = 0
-  while true
-    attempt += 1
-    if attempt <= 5
-      try
-        result = GeneralUtils.sendReceiveMqttMsg(outgoingMsg; timeout=120)
-        response = result[:response]
+  for attempt in 1:5
+    try
+      result = GeneralUtils.sendReceiveMqttMsg(outgoingMsg; timeout=120)
+      response = result[:response]
 
-        return (response[:text], response[:select], response[:reward], response[:isterminal])
-      catch e
-        io = IOBuffer()
-        showerror(io, e)
-        errorMsg = String(take!(io))
-        st = sprint((io, v) -> show(io, "text/plain", v), stacktrace(catch_backtrace()))
-        println("")
-        @warn "Error occurred: $errorMsg\n$st"
-        println("")
-      end
-
-    else
-      error("virtualWineCustomerChatbox failed to get a response")
+      return (response[:text], response[:select], response[:reward], response[:isterminal])
+    catch e
+      io = IOBuffer()
+      showerror(io, e)
+      errorMsg = String(take!(io))
+      st = sprint((io, v) -> show(io, "text/plain", v), stacktrace(catch_backtrace()))
+      println("")
+      @warn "Error occurred: $errorMsg\n$st"
+      println("")
     end
   end
+  error("virtualWineCustomerChatbox failed to get a response")
 end
 
 
@@ -252,77 +247,69 @@ julia>
 function jsoncorrection(a::T1, input::T2, 
     correctJsonExample::T3) where {T1<:agent, T2<:AbstractString, T3<:AbstractString}
 
-  attemptround = 0
   incorrectjson = deepcopy(input)
   correctjson = nothing
-  while true
-    attemptround += 1
-    if attemptround <= 5
-      try
-        d = copy(JSON3.read(incorrectjson))
-        correctjson = incorrectjson
-        break
-      catch e
-        @warn "Attempting correct JSON string. $attemptround"
-        e = """$e"""
-        if occursin("EOF", e)
-          e = split(e, "EOF")[1] * "EOF"
-        end
-        incorrectjson = deepcopy(input)
-        _prompt =
-        """
-        Your goal are:
-        1) Use the info why the given JSON string failed to load and provide a corrected version that can be loaded by Python's json.load function.
-        2) The user need Corrected JSON string only. Do not provide any other info.
 
-        $correctJsonExample
+  for attempt in 1:5
+    try
+      d = copy(JSON3.read(incorrectjson))
+      correctjson = incorrectjson
+      return correctjson
+    catch e
+      @warn "Attempting correct JSON string. Attempt $attempt"
+      e = """$e"""
+      if occursin("EOF", e)
+        e = split(e, "EOF")[1] * "EOF"
+      end
+      incorrectjson = deepcopy(input)
+      _prompt =
+      """
+      Your goal are:
+      1) Use the info why the given JSON string failed to load and provide a corrected version that can be loaded by Python's json.load function.
+      2) The user need Corrected JSON string only. Do not provide any other info.
 
-        Let's begin!
-        Given JSON string: $incorrectjson
-        The given JSON string failed to load previously because: $e
-        Corrected JSON string:
-        """
+      $correctJsonExample
 
-        # apply LLM specific instruct format
-        externalService = a.config[:externalservice][:text2textinstruct]
-        llminfo = externalService[:llminfo]
-        prompt = 
-        if llminfo[:name] == "llama3instruct"
-          formatLLMtext_llama3instruct("system", _prompt)
-        else
-          error("llm model name is not defied yet $(@__LINE__)")
-        end
+      Let's begin!
+      Given JSON string: $incorrectjson
+      The given JSON string failed to load previously because: $e
+      Corrected JSON string:
+      """
 
-        # send formatted input to user using GeneralUtils.sendReceiveMqttMsg
-        msgMeta = GeneralUtils.generate_msgMeta(
-          externalService[:mqtttopic],
-          senderName= "jsoncorrection",
-          senderId= a.id,
-          receiverName= "text2textinstruct",
-          mqttBroker= a.config[:mqttServerInfo][:broker],
-          mqttBrokerPort= a.config[:mqttServerInfo][:port],
-        )
+      # apply LLM specific instruct format
+      externalService = a.config[:externalservice][:text2textinstruct]
+      llminfo = externalService[:llminfo]
+      prompt = 
+      if llminfo[:name] == "llama3instruct"
+        formatLLMtext_llama3instruct("system", _prompt)
+      else
+        error("llm model name is not defied yet $(@__LINE__)")
+      end
 
-        outgoingMsg = Dict(
-          :msgMeta=> msgMeta,
-          :payload=> Dict(
-            :text=> prompt,
-            :kwargs=> Dict(
-              :max_tokens=> 512,
-              :stop=> ["<|eot_id|>"],
-              )
+      # send formatted input to user using GeneralUtils.sendReceiveMqttMsg
+      msgMeta = GeneralUtils.generate_msgMeta(
+        externalService[:mqtttopic],
+        senderName= "jsoncorrection",
+        senderId= a.id,
+        receiverName= "text2textinstruct",
+        mqttBroker= a.config[:mqttServerInfo][:broker],
+        mqttBrokerPort= a.config[:mqttServerInfo][:port],
+      )
+
+      outgoingMsg = Dict(
+        :msgMeta=> msgMeta,
+        :payload=> Dict(
+          :text=> prompt,
+          :kwargs=> Dict(
+            :max_tokens=> 512,
+            :stop=> ["<|eot_id|>"],
             )
           )
-        result = GeneralUtils.sendReceiveMqttMsg(outgoingMsg; timeout=120)
-        incorrectjson = result[:response][:text]
-      end
-    else
-      error("Can't fix JSON string")
-      break
+        )
+      result = GeneralUtils.sendReceiveMqttMsg(outgoingMsg; timeout=120)
+      incorrectjson = result[:response][:text]
     end
   end
-  
-  return correctjson
 end